chrome/common/extensions/docs/server2/caching_file_system.py - Issue 437323003: Docserver: Factor SamplesModel out of SamplesDataSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/caching_file_system.py

Issue 437323003: Docserver: Factor SamplesModel out of SamplesDataSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: The cron is on Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/api_data_source.py ('K') | « chrome/common/extensions/docs/server2/app.yaml ('k') | chrome/common/extensions/docs/server2/chained_compiled_file_system.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/caching_file_system.py

diff --git a/chrome/common/extensions/docs/server2/caching_file_system.py b/chrome/common/extensions/docs/server2/caching_file_system.py

index c0ff5d0b92d2256cf64464ed8b26f706837b1daa..15a81a36f8c4f78ff0a7ddbb23ca3dde5dcd53f5 100644

--- a/chrome/common/extensions/docs/server2/caching_file_system.py

+++ b/chrome/common/extensions/docs/server2/caching_file_system.py

@@ -7,7 +7,7 @@ import sys

from file_system import FileSystem, StatInfo, FileNotFoundError

from future import Future

-from path_util import IsDirectory

+from path_util import IsDirectory, ToDirectory

from third_party.json_schema_compiler.memoize import memoize

@@ -43,8 +43,7 @@ class CachingFileSystem(FileSystem):

# Always stat the parent directory, since it will have the stat of the child

# anyway, and this gives us an entire directory's stat info at once.

dir_path, file_path = posixpath.split(path)

- if dir_path and not dir_path.endswith('/'):

- dir_path += '/'

+ dir_path = ToDirectory(dir_path)

def make_stat_info(dir_stat):

'''Converts a dir stat into the correct resulting StatInfo; if the Stat