chrome/common/extensions/docs/server2/compiled_file_system.py - Issue 437323003: Docserver: Factor SamplesModel out of SamplesDataSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/compiled_file_system.py

Issue 437323003: Docserver: Factor SamplesModel out of SamplesDataSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/chained_compiled_file_system.py ('k') | chrome/common/extensions/docs/server2/cron.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/compiled_file_system.py

diff --git a/chrome/common/extensions/docs/server2/compiled_file_system.py b/chrome/common/extensions/docs/server2/compiled_file_system.py

index 2f7769e961f3be068f0a8c082803182998f6ea90..58ab967240dd191cd3200c8cc9cbde0bf4ae9182 100644

--- a/chrome/common/extensions/docs/server2/compiled_file_system.py

+++ b/chrome/common/extensions/docs/server2/compiled_file_system.py

@@ -8,7 +8,7 @@ import schema_util

from docs_server_utils import ToUnicode

from file_system import FileNotFoundError

from future import Future

-from path_util import AssertIsDirectory, AssertIsFile

+from path_util import AssertIsDirectory, AssertIsFile, ToDirectory

from third_party.handlebar import Handlebar

from third_party.json_schema_compiler import json_parse

from third_party.json_schema_compiler.memoize import memoize

@@ -236,8 +236,7 @@ class CompiledFileSystem(object):

return self._file_system.Stat(path).version

def GetFileListingVersion(self, path):

- if not path.endswith('/'):

- path += '/'

+ path = ToDirectory(path)

cache_entry = self._list_object_store.Get(path).Get()

if cache_entry is not None:

return cache_entry.version