Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

Issue 437313002: Media Galleries: Omit ById in various method names, since all operations are now by id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
diff --git a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
index f4e855c05351b8909c35f52ed90f39bafe40ca25..5639169060180afc8de56657ffd83fb30188529d 100644
--- a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
+++ b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
@@ -151,15 +151,14 @@ class MediaTransferProtocolDaemonClientImpl
}
// MediaTransferProtocolDaemonClient override.
- virtual void ReadFileChunkById(const std::string& handle,
- uint32 file_id,
- uint32 offset,
- uint32 bytes_to_read,
- const ReadFileCallback& callback,
- const ErrorCallback& error_callback) OVERRIDE {
+ virtual void ReadFileChunk(const std::string& handle,
+ uint32 file_id,
+ uint32 offset,
+ uint32 bytes_to_read,
+ const ReadFileCallback& callback,
+ const ErrorCallback& error_callback) OVERRIDE {
DCHECK_LE(bytes_to_read, kMaxChunkSize);
- dbus::MethodCall method_call(mtpd::kMtpdInterface,
- mtpd::kReadFileChunkById);
+ dbus::MethodCall method_call(mtpd::kMtpdInterface, mtpd::kReadFileChunk);
dbus::MessageWriter writer(&method_call);
writer.AppendString(handle);
writer.AppendUint32(file_id);
@@ -331,7 +330,7 @@ class MediaTransferProtocolDaemonClientImpl
callback.Run(file_entries);
}
- // Handles the result of ReadFileChunkById and calls |callback| or
+ // Handles the result of ReadFileChunk and calls |callback| or
// |error_callback|.
void OnReadFile(const ReadFileCallback& callback,
const ErrorCallback& error_callback,

Powered by Google App Engine
This is Rietveld 408576698