Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: chrome/browser/media_galleries/linux/mtp_device_task_helper.h

Issue 437313002: Media Galleries: Omit ById in various method names, since all operations are now by id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/linux/mtp_device_task_helper.h
diff --git a/chrome/browser/media_galleries/linux/mtp_device_task_helper.h b/chrome/browser/media_galleries/linux/mtp_device_task_helper.h
index ffe8afbcbac2f8070b386746ebe99d4edd59bc5a..f24251eedf9457e936c6f95d1b9f7fe7fdb1d34a 100644
--- a/chrome/browser/media_galleries/linux/mtp_device_task_helper.h
+++ b/chrome/browser/media_galleries/linux/mtp_device_task_helper.h
@@ -50,8 +50,7 @@ class MTPDeviceTaskHelper {
void OpenStorage(const std::string& storage_name,
const OpenStorageCallback& callback);
- // Dispatches the GetFileInfoById request to the
- // MediaTransferProtocolManager.
+ // Dispatches the GetFileInfo request to the MediaTransferProtocolManager.
//
// |file_id| specifies the id of the file whose details are requested.
//
@@ -60,10 +59,9 @@ class MTPDeviceTaskHelper {
//
// If there is an error, |error_callback| is invoked on the IO thread to
// notify the caller about the file error.
- void GetFileInfoById(
- uint32 file_id,
- const GetFileInfoSuccessCallback& success_callback,
- const ErrorCallback& error_callback);
+ void GetFileInfo(uint32 file_id,
+ const GetFileInfoSuccessCallback& success_callback,
+ const ErrorCallback& error_callback);
// Dispatches the read directory request to the MediaTransferProtocolManager.
//
@@ -77,9 +75,9 @@ class MTPDeviceTaskHelper {
//
// If there is an error, |error_callback| is invoked on the IO thread to
// notify the caller about the file error.
- void ReadDirectoryById(uint32 dir_id,
- const ReadDirectorySuccessCallback& success_callback,
- const ErrorCallback& error_callback);
+ void ReadDirectory(uint32 dir_id,
+ const ReadDirectorySuccessCallback& success_callback,
+ const ErrorCallback& error_callback);
// Forwards the WriteDataIntoSnapshotFile request to the MTPReadFileWorker
// object.
@@ -126,7 +124,7 @@ class MTPDeviceTaskHelper {
const MtpFileEntry& file_entry,
bool error) const;
- // Query callback for ReadDirectoryById().
+ // Query callback for ReadDirectory().
//
// If there is no error, |error| is set to false, |file_entries| has the
// directory file entries and |success_callback| is invoked on the IO thread
@@ -134,12 +132,11 @@ class MTPDeviceTaskHelper {
//
// If there is an error, |error| is set to true, |file_entries| is empty
// and |error_callback| is invoked on the IO thread to notify the caller.
- void OnDidReadDirectoryById(
- const ReadDirectorySuccessCallback& success_callback,
- const ErrorCallback& error_callback,
- const std::vector<MtpFileEntry>& file_entries,
- bool has_more,
- bool error) const;
+ void OnDidReadDirectory(const ReadDirectorySuccessCallback& success_callback,
+ const ErrorCallback& error_callback,
+ const std::vector<MtpFileEntry>& file_entries,
+ bool has_more,
+ bool error) const;
// Intermediate step to finish a ReadBytes request.
void OnGetFileInfoToReadBytes(

Powered by Google App Engine
This is Rietveld 408576698