Media Galleries: Omit ById in various method names, since all operations are now by id.

device/media_transfer_protocol/media_transfer_protocol_daemon_client.h

Index: device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
diff --git a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
index 2ea92d88aaadb86d0feaf1a8e5147e0f5cb5ed2b..821f277b887662f79a57b9c21fcf93181fd88930 100644
--- a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
+++ b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
@@ -125,17 +125,17 @@ class MediaTransferProtocolDaemonClient {
                            const GetFileInfoCallback& callback,
                            const ErrorCallback& error_callback) = 0;
 
-  // TODO(thestig): Rename to ReadFileChunk.
-  // Calls ReadFilePathById method. |callback| is called after the method call
+  // Calls ReadFileChunj method. |callback| is called after the method call

[tommycli, 2014/08/04 19:54:33]

typo

[Lei Zhang, 2014/08/04 20:10:16]

Done.

   // succeeds, otherwise, |error_callback| is called.
   // |file_id| is a MTP-device specific id for a file.
+  // |offset| is the offset into the file.
   // |bytes_to_read| cannot exceed 1 MiB.
-  virtual void ReadFileChunkById(const std::string& handle,
-                                 uint32 file_id,
-                                 uint32 offset,
-                                 uint32 bytes_to_read,
-                                 const ReadFileCallback& callback,
-                                 const ErrorCallback& error_callback) = 0;
+  virtual void ReadFileChunk(const std::string& handle,
+                             uint32 file_id,
+                             uint32 offset,
+                             uint32 bytes_to_read,
+                             const ReadFileCallback& callback,
+                             const ErrorCallback& error_callback) = 0;
 
   // Registers given callback for events. Should only be called once.
   // |storage_event_handler| is called when a mtp storage attach or detach