Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 437313002: Media Galleries: Omit ById in various method names, since all operations are now by id. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Project:
chromium
Visibility:
Public.

Description

Media Galleries: Omit ById in various method names, since all operations are now by id. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287461

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-04 19:51:52 UTC) #1
tommycli
lgtm https://codereview.chromium.org/437313002/diff/1/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h File device/media_transfer_protocol/media_transfer_protocol_daemon_client.h (right): https://codereview.chromium.org/437313002/diff/1/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h#newcode128 device/media_transfer_protocol/media_transfer_protocol_daemon_client.h:128: // Calls ReadFileChunj method. |callback| is called after ...
6 years, 4 months ago (2014-08-04 19:54:33 UTC) #2
Lei Zhang
https://codereview.chromium.org/437313002/diff/1/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h File device/media_transfer_protocol/media_transfer_protocol_daemon_client.h (right): https://codereview.chromium.org/437313002/diff/1/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h#newcode128 device/media_transfer_protocol/media_transfer_protocol_daemon_client.h:128: // Calls ReadFileChunj method. |callback| is called after the ...
6 years, 4 months ago (2014-08-04 20:10:16 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-04 20:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/437313002/20001
6 years, 4 months ago (2014-08-04 20:11:45 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 05:07:17 UTC) #6
Message was sent while issue was closed.
Change committed as 287461

Powered by Google App Engine
This is Rietveld 408576698