Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 437263002: Don't forward invalid line offsets for generated scripts to Dart_Load*. (Closed)

Created:
6 years, 4 months ago by rmacnak
Modified:
6 years, 4 months ago
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Don't forward invalid line offsets for generated scripts to Dart_Load*. BUG=http://dartbug.com/20307 R=vsm@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=179485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/bindings/dart/DartAsyncLoader.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
Goes with https://codereview.chromium.org/439733005/
6 years, 4 months ago (2014-08-04 17:15:57 UTC) #1
vsm
lgtm
6 years, 4 months ago (2014-08-04 17:17:03 UTC) #2
rmacnak
Committed patchset #1 manually as 179485 (presubmit successful).
6 years, 4 months ago (2014-08-04 17:21:26 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-04 18:28:45 UTC) #4
Message was sent while issue was closed. 
lgtm, thanks Ryan!

Powered by Google App Engine
This is Rietveld 408576698