Issue 43723002: Ensure list/string/isolate are enabled when main has arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43723002: Ensure list/string/isolate are enabled when main has arguments. (Closed)

Created:
7 years, 2 months ago by ngeoffray

Modified:
7 years, 2 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ensure list/string/isolate are enabled when main has arguments. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29243

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2	2 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/43723002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/43723002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1037 sdk/lib/_internal/compiler/implementation/compiler.dart:1037: "Error: '$MAIN' cannot have parameters."}); cannot have more ...

7 years, 2 months ago (2013-10-25 10:56:09 UTC) #2

ngeoffray

Thanks Florian. https://codereview.chromium.org/43723002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/43723002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1037 sdk/lib/_internal/compiler/implementation/compiler.dart:1037: "Error: '$MAIN' cannot have parameters."}); On 2013/10/25 ...

7 years, 2 months ago (2013-10-25 11:09:52 UTC) #3

ngeoffray

7 years, 2 months ago (2013-10-25 11:18:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r29243 (presubmit successful).

Expand Messages | Collapse Messages

Issue 43723002: Ensure list/string/isolate are enabled when main has arguments. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages