Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

Issue 437213005: Fixing problem with the maximize mode where MultiProfile windows do not get properly handled (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
diff --git a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
index a382c49b7b5d0d76e96ae9c8d63d8bfb64a808b8..2db975213c87b756df3148cc4cc9b20904e7ef8c 100644
--- a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
+++ b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
@@ -15,6 +15,7 @@
#include "ash/shell_delegate.h"
#include "ash/shell_window_ids.h"
#include "ash/system/tray/system_tray_notifier.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
#include "ash/wm/window_state.h"
#include "base/auto_reset.h"
#include "base/message_loop/message_loop.h"
@@ -692,6 +693,13 @@ void MultiUserWindowManagerChromeOS::SetWindowVisible(
aura::Window* window,
bool visible,
int animation_time_in_ms) {
+ // The MaximizeModeWindowManager will not handle invisible windows since they
+ // are not "active" upon manager creation. We therefore add these new windows
flackr 2014/08/05 18:10:11 Can you clarify what you mean by active? Is it vis
Mr4D (OOO till 08-26) 2014/08/06 20:31:47 Done.
+ // when they become visible - before they become visible. This way we reduce
+ // animation jank from multiple resizes.
+ if (visible)
+ ash::Shell::GetInstance()->maximize_mode_controller()->AddWindow(window);
flackr 2014/08/05 18:10:11 I'm a bit hesitant to require other parts of the U
Mr4D (OOO till 08-26) 2014/08/06 20:31:47 As discussed offline: This decision did not came e
+
AnimationSetter animation_setter(
window,
GetAdjustedAnimationTimeInMS(animation_time_in_ms));

Powered by Google App Engine
This is Rietveld 408576698