Fixing problem with the maximize mode where MultiProfile windows do not get properly handled

Fixing problem with the maximize mode where MultiProfile windows do not get properly handled

BUG=391334
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287949

[Mr4D (OOO till 08-26), 2014-08-04 16:41:08]

Robert, please have a look!

(Note: I kept the changes relatively confined since it might have to be
backmerged).

[flackr, 2014-08-05 18:10:11]

Can you add a unit test?

https://codereview.chromium.org/437213005/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/437213005/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:62:
!IsContainerWindow(window->parent()))
nit: curlies { }.

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:697: //
are not "active" upon manager creation. We therefore add these new windows
Can you clarify what you mean by active? Is it visible? Or in some container?

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:701:
ash::Shell::GetInstance()->maximize_mode_controller()->AddWindow(window);
I'm a bit hesitant to require other parts of the UI directly telling
MaximizeModeWindowManager about these things, can we find all inactive multi
profile windows from MaximizeModeWindowManager::MaximizeAllWindows or detect the
state change using observations?

[Mr4D (OOO till 08-26), 2014-08-06 20:31:47]

Addressed and unit test added. Please have another look!

https://codereview.chromium.org/437213005/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right):

https://codereview.chromium.org/437213005/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_manager.cc:62:
!IsContainerWindow(window->parent()))
On 2014/08/05 18:10:11, flackr wrote:
> nit: curlies { }.

Done.

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:697: //
are not "active" upon manager creation. We therefore add these new windows
On 2014/08/05 18:10:11, flackr wrote:
> Can you clarify what you mean by active? Is it visible? Or in some container?

Done.

https://codereview.chromium.org/437213005/diff/1/chrome/browser/ui/ash/multi_...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:701:
ash::Shell::GetInstance()->maximize_mode_controller()->AddWindow(window);
As discussed offline: This decision did not came easy, but given the constraints
this is the best which can be done here. I experimented a day with alternatives
and this is optimal. - So I leave this as is.

[flackr, 2014-08-06 21:11:39]

Thanks, LGTM

[Mr4D (OOO till 08-26), 2014-08-06 21:15:29]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-06 21:17:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/437213005/20001

[Mr4D (OOO till 08-26), 2014-08-06 22:10:15]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-06 22:11:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/437213005/40001

[commit-bot: I haz the power, 2014-08-07 03:07:21]

Change committed as 287949