Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 437213004: wtf/Vector.h included more than necessary (Closed)

Created:
6 years, 4 months ago by Gaja
Modified:
6 years, 4 months ago
CC:
aandrey+blink_chromium.org, abarth-chromium, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, ed+blinkwatch_opera.com, eustas+blink_chromium.org, jamesr, jbroman, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, webcomponents-bugzilla_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

wtf/Vector.h included more than necessary There are files that include Vector.h without needing it. That triggers builds bigger than needed when working on the Vector class. This CL does 2 things : 1. If any .cpp uses Vector and its corresponding .h does not use it, then include "wtf/Vector.h" in the .cpp itself. 2. Remove duplicate 'include "wtf/Vector.h"' from .cpp, if both .h & .cpp includes it. BUG=398455 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImport.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImport.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/ContentSearchUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/plugins/DOMPluginArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMPluginArray.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/FontCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Gaja
6 years, 4 months ago (2014-08-04 10:58:44 UTC) #1
Gaja
@jochen This is 2nd patch set for the same bug. Please review.
6 years, 4 months ago (2014-08-04 11:05:23 UTC) #2
Yoav Weiss
Looks good, but can you please run the test bots, so that we can be ...
6 years, 4 months ago (2014-08-04 11:24:22 UTC) #3
Gaja
On 2014/08/04 11:24:22, Yoav Weiss wrote: > Looks good, but can you please run the ...
6 years, 4 months ago (2014-08-04 11:26:07 UTC) #4
jochen (gone - plz use gerrit)
lgtm assuming green trybots
6 years, 4 months ago (2014-08-04 11:32:18 UTC) #5
Gaja
The CQ bit was checked by gajendra.n@samsung.com
6 years, 4 months ago (2014-08-04 11:52:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/437213004/1
6 years, 4 months ago (2014-08-04 11:53:45 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 12:52:51 UTC) #8
Message was sent while issue was closed.
Change committed as 179471

Powered by Google App Engine
This is Rietveld 408576698