Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: base/allocator/allocator.gyp

Issue 437163006: base/allocator: Hardcode TCMalloc optimization level to 2 on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Dale's comments. Also ditch mac settings. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/allocator.gyp
diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
index d76a31f4cf010fb7ec58c12a084ec8c1794757ef..323d79ede60e66be555c12d47f2b1c7abc712962 100644
--- a/base/allocator/allocator.gyp
+++ b/base/allocator/allocator.gyp
@@ -3,6 +3,16 @@
# found in the LICENSE file.
{
+ 'target_defaults': {
+ 'variables': {
+ # This code gets run a lot and debugged rarely, so it should be fast
+ # by default. See http://crbug.com/388949.
+ 'debug_optimize': '2',
+ 'win_debug_Optimization': '2',
+ # Run time checks are incompatible with any level of optimizations.
+ 'win_debug_RuntimeChecks': '0',
+ },
+ },
'variables': {
'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
'use_vtable_verify%': 0,
@@ -306,9 +316,6 @@
# e.g. for profiling (it's more rare to profile Debug builds,
# but people sometimes need to do that).
'disable_debugallocation%': 0,
- # This code gets run a lot and debugged rarely, so it should be fast
- # by default. See http://crbug.com/388949.
- 'debug_optimize': 2,
},
'conditions': [
# TODO(phajdan.jr): Also enable on Windows.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698