base/allocator: Hardcode TCMalloc optimization level to 2 on Windows.

base/allocator/allocator.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
+  'target_defaults': {
+    'variables': {
+      # This code gets run a lot and debugged rarely, so it should be fast
+      # by default. See http://crbug.com/388949.
+      'debug_optimize': '2',
+      'mac_debug_optimization': '2',
+      # In addition to the above reasons, /Od optimization won't remove symbols

[DaleCurtis, 2014/08/04 18:58:17]

While true, this comment is probably not relevant to base/. Up to you if you
want to keep it.

[willchan no longer on Chromium, 2014/08/04 19:05:22]

Done.

+      # that are under "if (0)" style sections.  Which lead to link time errors
+      # when for example it tries to link an ARM symbol on X86.
+      'win_debug_Optimization': '2',
+      # Run time checks are incompatible with any level of optimizations.
+      'win_debug_RuntimeChecks': '0',
+      'conditions': [
+        ['OS == "win"', {
+          # Setting the optimizations to 'speed' or to 'max' results in a lot of

[DaleCurtis, 2014/08/04 18:58:17]

I'm not sure you want this setting, it's only needed for ffmpeg eccentricities. 
Ditto on the comment.

[willchan no longer on Chromium, 2014/08/04 19:05:22]

Done.

+          # unresolved symbols. The only supported mode is 'size' (see
+          # crbug.com/264459).
+          'optimize' :'size',
+        }],
+      ],
+    },
+  },
   'variables': {
     'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
     'use_vtable_verify%': 0,
   },
   'targets': [
     # Only executables and not libraries should depend on the
     # allocator target; only the application (the final executable)
     # knows what allocator makes sense.
     {
       'target_name': 'allocator',
@@ skipping 283 matching lines @@
           'msvs_settings': {
             'VCCLCompilerTool': {
               'RuntimeLibrary': '0',
             },
           },
           'variables': {
             # Provide a way to force disable debugallocation in Debug builds,
             # e.g. for profiling (it's more rare to profile Debug builds,
             # but people sometimes need to do that).
             'disable_debugallocation%': 0,
-            # This code gets run a lot and debugged rarely, so it should be fast
-            # by default. See http://crbug.com/388949.
-            'debug_optimize': 2,
           },
           'conditions': [
             # TODO(phajdan.jr): Also enable on Windows.
             ['disable_debugallocation==0 and OS!="win"', {
               'defines': [
                 # Use debugallocation for Debug builds to catch problems early
                 # and cleanly, http://crbug.com/30715 .
                 'TCMALLOC_FOR_DEBUGALLOCATION',
               ],
             }],
@@ skipping 301 matching lines @@
           'sources': [
             'type_profiler_map_unittest.cc',
             '<(tcmalloc_dir)/src/gperftools/type_profiler_map.h',
             '<(tcmalloc_dir)/src/type_profiler_map.cc',
           ],
         },
       ],
     }],
   ],
 }