Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 437143002: Re-enable PPAPI WebSocket browser tests (Closed)

Created:
6 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Re-enable Pepper WebSocket browser test items BUG=389084, 396399 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287607

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -33 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +10 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 4 months ago (2014-08-05 05:43:48 UTC) #1
tyoshino (SeeGerritForStatus)
Thanks Adam for running the try job. First one failed but I rerun it and ...
6 years, 4 months ago (2014-08-05 09:04:47 UTC) #2
Adam Rice
lgtm
6 years, 4 months ago (2014-08-05 09:36:56 UTC) #3
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-05 09:38:14 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was unchecked by tyoshino@chromium.org
6 years, 4 months ago (2014-08-05 09:38:20 UTC) #5
tyoshino (SeeGerritForStatus)
+dmichael
6 years, 4 months ago (2014-08-05 09:39:04 UTC) #6
dmichael (off chromium)
lgtm Please check the flakiness dashboard in a day or two to make sure it ...
6 years, 4 months ago (2014-08-05 16:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/437143002/20001
6 years, 4 months ago (2014-08-05 16:38:20 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 20:34:04 UTC) #9
commit-bot: I haz the power
Change committed as 287607
6 years, 4 months ago (2014-08-05 21:54:28 UTC) #10
tyoshino (SeeGerritForStatus)
6 years, 4 months ago (2014-08-06 01:55:52 UTC) #11
Message was sent while issue was closed.
On 2014/08/05 16:37:43, dmichael wrote:
> lgtm
> 
> Please check the flakiness dashboard in a day or two to make sure it has
stopped
> flaking. Thanks for fixing these!

Yes. I'm going to be watching it carefully for coming days.

Powered by Google App Engine
This is Rietveld 408576698