Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 437113002: Delete the old SSL interstitial and Finch trial (Closed)

Created:
6 years, 4 months ago by felt
Modified:
6 years, 4 months ago
Reviewers:
palmer, Lei Zhang, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, Randy Smith (Not in Mondays), radhikabhar
Project:
chromium
Visibility:
Public.

Description

Delete the old SSL interstitial and Finch trial BUG=386033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287450

Patch Set 1 #

Patch Set 2 : Remove flags #

Patch Set 3 : Remove html|js|css files #

Patch Set 4 : Removing IDS_FLAGS_SSL_INTERSTITIAL strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -538 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/ssl/blocking.css View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/resources/ssl/blocking.html View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/resources/ssl/blocking.js View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.css View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.js View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/ssl/roadblock.html View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/resources/ssl/roadblock.js View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/resources/ssl/ssl_errors_common.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 3 chunks +1 line, -213 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
felt
palmer, dbeam, PTAL.
6 years, 4 months ago (2014-08-04 01:27:54 UTC) #1
Dan Beam
lgtm \o/
6 years, 4 months ago (2014-08-04 16:04:57 UTC) #2
palmer
lgtm
6 years, 4 months ago (2014-08-04 19:02:02 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 4 months ago (2014-08-04 19:08:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/437113002/40001
6 years, 4 months ago (2014-08-04 19:09:12 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 19:53:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 19:55:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/1904)
6 years, 4 months ago (2014-08-04 19:55:52 UTC) #8
felt
thestig@, can I have an OWNERS review for c/b/browser_resources.grd?
6 years, 4 months ago (2014-08-04 20:33:27 UTC) #9
Lei Zhang
Please remove IDS_FLAGS_SSL_INTERSTITIAL_TRIAL_NAME and other resources as well?
6 years, 4 months ago (2014-08-04 20:46:30 UTC) #10
felt
On 2014/08/04 20:46:30, Lei Zhang wrote: > Please remove IDS_FLAGS_SSL_INTERSTITIAL_TRIAL_NAME and other resources as well? ...
6 years, 4 months ago (2014-08-04 20:49:17 UTC) #11
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-04 20:51:06 UTC) #12
felt
The CQ bit was checked by felt@chromium.org
6 years, 4 months ago (2014-08-04 20:51:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/437113002/60001
6 years, 4 months ago (2014-08-04 20:52:44 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 04:17:06 UTC) #15
Message was sent while issue was closed. 
Change committed as 287450

Powered by Google App Engine
This is Rietveld 408576698