Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 437089: Remove Content-Type workaround for cached resources (Closed)

Created:
11 years ago by apavlov
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com, pfeldman
Visibility:
Public.

Description

Remove Content-Type workaround for cached resources BUG=27364 TEST=DevToolsSanityTest.TestCachedResourceMimeType Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33206

Patch Set 1 #

Patch Set 2 : Test #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/glue/devtools/js/devtools.js View 1 chunk +0 lines, -17 lines 0 comments Download
M webkit/glue/devtools/js/tests.js View 1 chunk +38 lines, -0 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
apavlov
Please have a look.
11 years ago (2009-11-26 12:41:51 UTC) #1
yurys
LGTM http://codereview.chromium.org/437089/diff/3/6 File webkit/glue/devtools/js/tests.js (right): http://codereview.chromium.org/437089/diff/3/6#newcode374 webkit/glue/devtools/js/tests.js:374: this.addSniffer(WebInspector, 'updateResource', are you sure WebInspector.updateResponse cannot have ...
11 years ago (2009-11-26 12:56:21 UTC) #2
apavlov
11 years ago (2009-11-26 13:01:45 UTC) #3
http://codereview.chromium.org/437089/diff/3/6
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/437089/diff/3/6#newcode374
webkit/glue/devtools/js/tests.js:374: this.addSniffer(WebInspector,
'updateResource',
On 2009/11/26 12:56:22, Yury Semikhatsky wrote:
> are you sure WebInspector.updateResponse cannot have been called before this
> line?

The test logic is a replica of the TestSuite.prototype.testResourceHeaders which
seems to work fine. I believe enabling the resource tracking at the end of the
method induces resource reloading.

http://codereview.chromium.org/437089/diff/3/6#newcode384
webkit/glue/devtools/js/tests.js:384: test.assertEquals('text/html',
payload.mimeType);
On 2009/11/26 12:56:22, Yury Semikhatsky wrote:
> is it possible to fix mime type for .js files? if not please add comment why
I'm somewhat reluctant to fix the server in the same CL (even though it's a good
idea to add the most used mime types).

> mime type is text/html
The comment is the previous line.

Powered by Google App Engine
This is Rietveld 408576698