Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 437083004: Keep function.prototype fast. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Keep function.prototype fast. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22826

Patch Set 1 #

Patch Set 2 : Skip hack to keep prototypes fast #

Patch Set 3 : Unbreak #

Patch Set 4 : Add TODO and make .prototype fast on creating the initial map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 3 chunks +16 lines, -10 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -0 lines 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-04 11:34:18 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-08-04 12:51:32 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-04 15:02:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as 22826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698