Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 437078: Report active extensions in crash reports (windows only). (Closed)
Patch Set: Rework Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_service.cc
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index b185150b2aed880ef7566beafd98fd5c3996e37f..2a40a37e7d8c9ac55cb0f33dd00b5c7d6832bca5 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/extensions/external_pref_extension_provider.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/net/chrome_url_request_context.h"
+#include "chrome/common/child_process_logging.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
@@ -410,6 +411,8 @@ void ExtensionsService::NotifyExtensionLoaded(Extension* extension) {
void ExtensionsService::NotifyExtensionUnloaded(Extension* extension) {
LOG(INFO) << "Sending EXTENSION_UNLOADED";
+ UpdateActiveExtensionsInCrashReporter();
+
NotificationService::current()->Notify(
NotificationType::EXTENSION_UNLOADED,
Source<Profile>(profile_),
@@ -621,6 +624,16 @@ void ExtensionsService::OnExtensionLoaded(Extension* extension,
break;
}
}
+
+ UpdateActiveExtensionsInCrashReporter();
+}
+
+void ExtensionsService::UpdateActiveExtensionsInCrashReporter() {
+ std::vector<std::string> extension_ids;
+ for (size_t i = 0; i < extensions_.size(); ++i)
+ extension_ids.push_back(extensions_[i]->id());
+
+ child_process_logging::SetActiveExtensions(extension_ids);
}
void ExtensionsService::OnExtensionInstalled(Extension* extension,

Powered by Google App Engine
This is Rietveld 408576698