Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 437070: Merge 32701 - Don't do work in the SharedIOBuffer constructor; ... (Closed)

Created:
11 years ago by Mark Larson (Google)
Modified:
9 years, 7 months ago
Reviewers:
hawk
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Merge 32701 - Don't do work in the SharedIOBuffer constructor; use an Init method instead. This eliminates instances of allocatedbutinvalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug. The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it. BUG=16371 TEST=none Review URL: http://codereview.chromium.org/391009 TBR=hawk@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M base/shared_memory_posix.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.cc View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Larson (Google)
11 years ago (2009-11-25 21:38:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698