Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 437066: Merge 33079 - Mac: give visual feedback for bookmark button drags.... (Closed)

Created:
11 years ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 33079 - Mac: give visual feedback for bookmark button drags. Draw an "ugly black bar" (where "black" is actually a theme colour) to indicate where a bookmark button that's being dragged will end up if dropped. This is a stopgap measure for the beta. Later, we will make the buttons move around instead (even if implementable in the time remaining, such animations would be a crash risk). BUG=17608 TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes. Review URL: http://codereview.chromium.org/437051 TBR=viettrungluu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -13 lines) Patch
M chrome/browser/cocoa/bookmark_bar_controller.h View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 6 chunks +74 lines, -10 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view.mm View 1 chunk +60 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view_unittest.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_button.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
11 years ago (2009-11-25 20:37:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698