Issue 437060: Fixes infinite loop within the JS of the news extension that was causing a ne...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437060: Fixes infinite loop within the JS of the news extension that was causing a ne... (Closed)

Created:
11 years ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes infinite loop within the JS of the news extension that was causing a never-ending CPU spike upon expanding a story. BUG=28428 TEST=Install the extension, expand a story, notice lack of CPU spike. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33077

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	chrome/common/extensions/docs/examples/extensions/news/feed.html	View		5 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years ago (2009-11-25 17:22:50 UTC) #2

LGTM

Thanks for tracking this down.  In retrospect, a really dumb bug.  I'll upload a
new version of this to the gallery after you land the change.

Expand Messages | Collapse Messages