Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 437033002: Elide gn desc --tree output by default. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Elide gn desc --tree output by default. When gn's desc command is used with --tree, it prints a dependency tree. But recursively printing the dependency tree of a high-level target in Chrome prints too much output to be useful because it's printing, e.g. base and it's deps over and over (//chrome/browser-s --tree is 3210166 lines). With this patch, a target will be recursed into the first time it's printed, but subsequent times the children will be elided with "..." This brings down //chrome/browser to 2050 lines. The previous behavior is still available (it could be useful in certain cases) via "--tree --all". This also updates an optimization comment in the the optimization setup (optimize_max isn't just Windows-only). R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/command_desc.cc View 6 chunks +45 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 4 months ago (2014-08-02 22:03:09 UTC) #1
DaleCurtis
lgtm
6 years, 4 months ago (2014-08-04 17:30:10 UTC) #2
brettw
6 years, 4 months ago (2014-08-05 01:00:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 287424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698