Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 437031: Add a feature to the MockSocket so that it can support simulation... (Closed)

Created:
11 years ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Add a feature to the MockSocket so that it can support simulation of partial writes. For example, suppose the application under test is doing a write such as: Write("foobar", 6); // 6 bytes Normally you could test this with MockWrite(true, "foobar", 6); Now you can also test this with: WriteList { MockWrite(true, "foo", 3); MockWrite(true, "bar", 3); } BUG=none TEST=this is the test! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M net/socket/socket_test_util.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Belshe
This change works just fine, as we discussed.
11 years ago (2009-11-24 01:13:17 UTC) #1
eroman
11 years ago (2009-11-24 04:11:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698