Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 437013002: Make signin_scoped_device_id enabled by default. (Closed)

Created:
6 years, 4 months ago by pavely
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make signin_scoped_device_id enabled by default. I've landed all client side patches necessary for this feature. Time to enable it by default for M38. BUG=382968 R=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pavely
6 years, 4 months ago (2014-08-02 05:33:17 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Awesome Pavel!
6 years, 4 months ago (2014-08-04 15:33:06 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 4 months ago (2014-08-04 17:05:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/437013002/1
6 years, 4 months ago (2014-08-04 17:07:00 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:37:43 UTC) #5
Message was sent while issue was closed.
Change committed as 287379

Powered by Google App Engine
This is Rietveld 408576698