Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 436963003: [Telemetry] Fix android unittests that run after AndroidBrowserFinderTest. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix android unittests that run after AndroidBrowserFinderTest. It was leaving the CanFindAvailableBrowsers method in a bad state. BUG=337829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -44 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 3 chunks +24 lines, -34 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 4 months ago (2014-08-01 22:36:08 UTC) #1
dtu
lgtm
6 years, 4 months ago (2014-08-01 22:39:25 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-01 22:41:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/436963003/1
6 years, 4 months ago (2014-08-01 22:44:43 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 07:56:37 UTC) #5
Message was sent while issue was closed.
Change committed as 287184

Powered by Google App Engine
This is Rietveld 408576698