Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 436933002: Fix the UUID structure (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Fix the UUID structure to have distinct fields, as expected by Breakpad’s minidump reader. TEST=util_test UUID.UUID R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5bbb7e8abbe0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -43 lines) Patch
M util/misc/uuid.h View 1 chunk +14 lines, -5 lines 0 comments Download
M util/misc/uuid.cc View 1 chunk +22 lines, -30 lines 0 comments Download
M util/misc/uuid_test.cc View 3 chunks +34 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-01 19:09:59 UTC) #1
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-01 19:59:32 UTC) #2
Mark Mentovai
6 years, 4 months ago (2014-08-01 20:11:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 5bbb7e8abbe0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698