Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 436883002: Web Animations: guard testRunner usages. (Closed)

Created:
6 years, 4 months ago by dshwang
Modified:
6 years, 4 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Web Animations: guard testRunner usages. When testing web animations test htmls on chrome, "Uncaught ReferenceError: testRunner is not defined" exception is fired. So guard testRunner for convenience. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179917

Patch Set 1 #

Patch Set 2 : fix errata #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M LayoutTests/web-animations-api/font-builder-crash.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/player-cancel-finishes.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/player-finish-event.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/player-finish-repeats.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/player-finish-sample-only.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/resource-loading.html View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dshwang
could you review this simple cl?
6 years, 4 months ago (2014-08-01 13:11:41 UTC) #1
Timothy Loh
On 2014/08/01 13:11:41, dshwang wrote: > could you review this simple cl? Why are some ...
6 years, 4 months ago (2014-08-01 13:41:06 UTC) #2
dshwang
On 2014/08/01 13:41:06, Timothy Loh wrote: > On 2014/08/01 13:11:41, dshwang wrote: > > could ...
6 years, 4 months ago (2014-08-01 13:55:40 UTC) #3
dshwang
On 2014/08/01 13:41:06, Timothy Loh wrote: > On 2014/08/01 13:11:41, dshwang wrote: > > could ...
6 years, 4 months ago (2014-08-01 13:57:24 UTC) #4
dshwang
Could you review again? Thank you.
6 years, 4 months ago (2014-08-04 10:19:02 UTC) #5
samli
+timloh
6 years, 4 months ago (2014-08-05 09:06:53 UTC) #6
Timothy Loh
On 2014/08/05 09:06:53, samli wrote: > +timloh seems fine, lgtm
6 years, 4 months ago (2014-08-10 23:32:33 UTC) #7
dshwang
On 2014/08/10 23:32:33, Timothy Loh wrote: > On 2014/08/05 09:06:53, samli wrote: > > +timloh ...
6 years, 4 months ago (2014-08-11 07:05:08 UTC) #8
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 4 months ago (2014-08-11 07:05:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/436883002/20001
6 years, 4 months ago (2014-08-11 07:05:23 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:04:53 UTC) #11
Message was sent while issue was closed.
Change committed as 179917

Powered by Google App Engine
This is Rietveld 408576698