Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 436873003: Make telemetry platform a singleton (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase_again Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/possible_browser.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/tab_unittest.py
diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py
index 1df26236334baf972b0b75a28c312b5fa31955e8..bf9250edc897154a5d3e150c6574c4ce6a583ddc 100644
--- a/tools/telemetry/telemetry/core/tab_unittest.py
+++ b/tools/telemetry/telemetry/core/tab_unittest.py
@@ -19,6 +19,10 @@ def _IsDocumentVisible(tab):
return not tab.EvaluateJavaScript('document.hidden || document.webkitHidden')
+class FakePlatformBackend(object):
+ def __init__(self):
+ self.platform = FakePlatform()
+
class FakePlatform(object):
def __init__(self):
self._is_video_capture_running = False
@@ -83,14 +87,16 @@ class TabTest(tab_test_case.TabTestCase):
#pylint: disable=W0212
def testIsVideoCaptureRunning(self):
- original_platform = self._tab.browser._platform
- self._tab.browser._platform = FakePlatform()
- self.assertFalse(self._tab.is_video_capture_running)
- self._tab.StartVideoCapture(min_bitrate_mbps=2)
- self.assertTrue(self._tab.is_video_capture_running)
- self.assertIsNotNone(self._tab.StopVideoCapture())
- self.assertFalse(self._tab.is_video_capture_running)
- self._tab.browser._platform = original_platform
+ original_platform_backend = self._tab.browser._platform_backend
+ try:
+ self._tab.browser._platform_backend = FakePlatformBackend()
+ self.assertFalse(self._tab.is_video_capture_running)
+ self._tab.StartVideoCapture(min_bitrate_mbps=2)
+ self.assertTrue(self._tab.is_video_capture_running)
+ self.assertIsNotNone(self._tab.StopVideoCapture())
+ self.assertFalse(self._tab.is_video_capture_running)
+ finally:
+ self._tab.browser._platform_backend = original_platform_backend
def testHighlight(self):
self.assertEquals(self._tab.url, 'about:blank')
« no previous file with comments | « tools/telemetry/telemetry/core/possible_browser.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698