tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py - Issue 436873003: Make telemetry platform a singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py

Issue 436873003: Make telemetry platform a singleton (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase_again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend_unittest.py ('k') | tools/telemetry/telemetry/core/possible_browser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py

index 2908e7ecc80892c33dc36d847c3a83e204ac500c..2b71ca19b2d350780fc9c2157266201d90fa08a1 100644

--- a/tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py

@@ -6,7 +6,7 @@ import sys

import unittest

from telemetry import benchmark

-from telemetry.core.platform import factory

+from telemetry.core import platform as platform_module

from telemetry.core.platform import posix_platform_backend

@@ -53,10 +53,10 @@ class PosixPlatformBackendTest(unittest.TestCase):

@benchmark.Enabled('linux', 'mac')

def testIsApplicationRunning(self):

- backend = factory.GetPlatformBackendForCurrentOS()

+ platform = platform_module.GetHostPlatform()

- self.assertFalse(backend.IsApplicationRunning('This_Is_A_Bad___App__Name'))

+ self.assertFalse(platform.IsApplicationRunning('This_Is_A_Bad___App__Name'))

sys_exe = os.path.basename(sys.executable)

- self.assertTrue(backend.IsApplicationRunning(sys_exe))

+ self.assertTrue(platform.IsApplicationRunning(sys_exe))

self.assertFalse(

- backend.IsApplicationRunning('%s append_bad_after_space' % sys_exe))

+ platform.IsApplicationRunning('%s append_bad_after_space' % sys_exe))