Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 436873003: Make telemetry platform a singleton (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase_again Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
index ae0a39ed5685c742724a6993d6667b49ba5e6d35..e0f43a5d2a8c50ea9fb6f1097f13e8d77c1cb003 100644
--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
@@ -8,10 +8,10 @@ import os
import sys
from telemetry.core import browser
+from telemetry.core import platform as platform_module
from telemetry.core import possible_browser
from telemetry.core import util
from telemetry.core.backends.webdriver import webdriver_ie_backend
-from telemetry.core.platform import factory
from telemetry.util import support_binaries
# Try to import the selenium python lib which may be not available.
@@ -43,14 +43,20 @@ class PossibleWebDriverBrowser(possible_browser.PossibleBrowser):
assert browser_type in ALL_BROWSER_TYPES, \
'Please add %s to ALL_BROWSER_TYPES' % browser_type
- @property
- def _platform_backend(self):
- return factory.GetPlatformBackendForCurrentOS()
-
def CreateWebDriverBackend(self, platform_backend):
raise NotImplementedError()
+ def _InitPlatformIfNeeded(self):
+ if self._platform:
+ return
+
+ self._platform = platform_module.GetHostPlatform()
+
+ # pylint: disable=W0212
+ self._platform_backend = self._platform._platform_backend
+
def Create(self):
+ self._InitPlatformIfNeeded()
backend = self.CreateWebDriverBackend(self._platform_backend)
return browser.Browser(backend, self._platform_backend)
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698