Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 436873003: Make telemetry platform a singleton (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase_again Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
index ac0c532fa4477b3af9b642487da6b238f0ff5b34..a0eab96f1c4e8267efa8aaa28ef305d098ac0332 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
@@ -13,6 +13,7 @@ import sys
from telemetry import decorators
from telemetry.core import browser
from telemetry.core import platform
+from telemetry.core import platform as platform_module
from telemetry.core import possible_browser
from telemetry.core import util
from telemetry.core.backends import adb_commands
@@ -93,14 +94,18 @@ class PossibleAndroidBrowser(possible_browser.PossibleBrowser):
def __repr__(self):
return 'PossibleAndroidBrowser(browser_type=%s)' % self.browser_type
- @property
- @decorators.Cache
- def _platform_backend(self):
- return android_platform_backend.AndroidPlatformBackend(
+ def _InitPlatformIfNeeded(self):
+ if self._platform:
+ return
+
+ self._platform_backend = android_platform_backend.AndroidPlatformBackend(
self._backend_settings.adb.device(),
self.finder_options.no_performance_mode)
+ self._platform = platform_module.Platform(self._platform_backend)
def Create(self):
+ self._InitPlatformIfNeeded()
+
use_rndis_forwarder = (self.finder_options.android_rndis or
self.finder_options.browser_options.netsim or
platform.GetHostPlatform().GetOSName() != 'linux')
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698