Issue 436873002: DevTools: count the number of consoleProfile and consoleTimeline calls.

Issue 436873002: DevTools: count the number of consoleProfile and consoleTimeline calls. (Closed)

Created:
6 years, 4 months ago by loislo

Modified:
6 years, 4 months ago

Reviewers:
alph, pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: count the number of consoleProfile and consoleTimeline calls. We would like to know stats about consoleProfile and consoleTimeline usage in the field. If they are small we would like to deprecate and remove these commands. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179400

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	Source/core/frame/UseCounter.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorConsoleAgent.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.cpp	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/436873002/diff/1/Source/core/inspector/InspectorProfilerAgent.cpp File Source/core/inspector/InspectorProfilerAgent.cpp (right): https://codereview.chromium.org/436873002/diff/1/Source/core/inspector/InspectorProfilerAgent.cpp#newcode35 Source/core/inspector/InspectorProfilerAgent.cpp:35: #include "core/dom/ExecutionContext.h" You don't seem to need this ...

6 years, 4 months ago (2014-08-01 13:06:40 UTC) #2

loislo

https://codereview.chromium.org/436873002/diff/1/Source/core/inspector/InspectorProfilerAgent.cpp File Source/core/inspector/InspectorProfilerAgent.cpp (right): https://codereview.chromium.org/436873002/diff/1/Source/core/inspector/InspectorProfilerAgent.cpp#newcode35 Source/core/inspector/InspectorProfilerAgent.cpp:35: #include "core/dom/ExecutionContext.h" On 2014/08/01 13:06:40, yurys wrote: > You ...

6 years, 4 months ago (2014-08-01 13:32:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/436873002/20001

6 years, 4 months ago (2014-08-01 13:33:24 UTC) #7

Message was sent while issue was closed.

Change committed as 179400

Expand Messages | Collapse Messages