Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issue 436843006: Closure compile JS files with GYP. (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, Vitaly Pavlenko
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : merge #

Patch Set 2 : add more inputs #

Patch Set 3 : rename to compile_js.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -172 lines) Patch
A third_party/closure_compiler/build/inputs.py View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/closure_compiler/build/outputs.py View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/closure_compiler/checker.py View 5 chunks +32 lines, -63 lines 0 comments Download
D third_party/closure_compiler/checker_test.py View 1 chunk +0 lines, -102 lines 0 comments Download
A third_party/closure_compiler/compile_js.gypi View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/closure_compiler/processor.py View 1 chunk +67 lines, -0 lines 0 comments Download
A + third_party/closure_compiler/processor_test.py View 6 chunks +11 lines, -7 lines 0 comments Download
A ui/webui/resources/js/chromeos/compiled_resources.gyp View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A ui/webui/resources/js/compiled_resources.gyp View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
6 years, 4 months ago (2014-08-02 01:45:23 UTC) #1
Dan Beam
+vitalyp@ FYI
6 years, 4 months ago (2014-08-04 23:31:47 UTC) #2
Dan Beam
ping darin@
6 years, 4 months ago (2014-08-06 21:22:20 UTC) #3
darin (slow to review)
I don't think I'm the best reviewer for this. I'm sure there are better reviewers ...
6 years, 4 months ago (2014-08-06 22:22:50 UTC) #4
Dan Beam
-darin, +arv
6 years, 4 months ago (2014-08-06 22:36:39 UTC) #5
Dan Beam
ping arv@
6 years, 4 months ago (2014-08-07 18:50:44 UTC) #6
Dan Beam
ping
6 years, 4 months ago (2014-08-08 17:30:06 UTC) #7
arv (Not doing code reviews)
LGTM In general these changes are better reviewed by someone knowing the build system.
6 years, 4 months ago (2014-08-11 17:41:25 UTC) #8
Dan Beam
6 years, 4 months ago (2014-08-11 18:45:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as 288750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698