Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 436753002: Extend ProofVerifierChromium and ProofVerifyDetailsChromium. (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
Reviewers:
agl, Ryan Hamilton
Project:
chromium
Visibility:
Public.

Description

[Replaced by https://codereview.chromium.org/439133002 ] Extend ProofVerifierChromium and ProofVerifyDetailsChromium. R=agl@chromium.org,rch@chromium.org BUG=399457

Patch Set 1 #

Patch Set 2 : Remove an unneeded member of ProofVerifierChromium #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -17 lines) Patch
M net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 4 chunks +10 lines, -1 line 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 8 chunks +74 lines, -6 lines 1 comment Download
M net/quic/quic_client_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wtc
6 years, 4 months ago (2014-07-31 22:11:47 UTC) #1
agl
lgtm
6 years, 4 months ago (2014-07-31 22:15:28 UTC) #2
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-07-31 22:28:21 UTC) #3
wtc
https://codereview.chromium.org/436753002/diff/20001/net/quic/crypto/proof_verifier_chromium.cc File net/quic/crypto/proof_verifier_chromium.cc (right): https://codereview.chromium.org/436753002/diff/20001/net/quic/crypto/proof_verifier_chromium.cc#newcode239 net/quic/crypto/proof_verifier_chromium.cc:239: #if defined(OFFICIAL_BUILD) && !defined(OS_ANDROID) && !defined(OS_IOS) Adam: I didn't ...
6 years, 4 months ago (2014-08-01 21:46:36 UTC) #4
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-03 10:42:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/436753002/20001
6 years, 4 months ago (2014-08-03 10:42:45 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-03 10:53:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-03 10:54:27 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 10:54:28 UTC) #9
Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36853)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

Powered by Google App Engine
This is Rietveld 408576698