[Sync] Use OnSingleDataTypeUnrecoverableError for all errors

chrome/browser/sync/glue/bookmark_change_processor.cc

Index: chrome/browser/sync/glue/bookmark_change_processor.cc
diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc
index 8e31f924e91a83881be83b3513ac16618d1a4dab..1c4a20222c019800fc7e371800435a51d157e142 100644
--- a/chrome/browser/sync/glue/bookmark_change_processor.cc
+++ b/chrome/browser/sync/glue/bookmark_change_processor.cc
@@ -120,8 +120,11 @@ void BookmarkChangeProcessor::RemoveSyncNodeHierarchy(
     syncer::WriteNode topmost_sync_node(&trans);
     if (!model_associator_->InitSyncNodeFromChromeId(topmost->id(),
                                                      &topmost_sync_node)) {
-      error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                          std::string());
+      syncer::SyncError error(FROM_HERE,
+                              syncer::SyncError::DATATYPE_ERROR,
+                              "Failed to init sync node from chrome node",
+                              syncer::BOOKMARKS);
+      error_handler()->OnSingleDataTypeUnrecoverableError(error);
       return;
     }
     // Check that |topmost| has been unlinked.
@@ -163,8 +166,11 @@ void BookmarkChangeProcessor::RemoveAllChildNodes(
   syncer::WriteNode topmost_node(trans);
   if (!model_associator_->InitSyncNodeFromChromeId(topmost_node_id,
                                                    &topmost_node)) {
-    error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                        std::string());
+    syncer::SyncError error(FROM_HERE,
+                            syncer::SyncError::DATATYPE_ERROR,
+                            "Failed to init sync node from chrome node",
+                            syncer::BOOKMARKS);
+    error_handler()->OnSingleDataTypeUnrecoverableError(error);
     return;
   }
   const int64 topmost_sync_id = topmost_node.GetId();
@@ -272,8 +278,12 @@ int64 BookmarkChangeProcessor::CreateSyncNode(const BookmarkNode* parent,
 
   // Actually create the node with the appropriate initial position.
   if (!PlaceSyncNode(CREATE, parent, index, trans, &sync_child, associator)) {
-    error_handler->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-        "Sync node creation failed; recovery unlikely");
+

[haitaol1, 2014/08/07 00:49:48]

empty line

[Nicolas Zea, 2014/08/07 18:14:54]

Done.

+    syncer::SyncError error(FROM_HERE,
+                            syncer::SyncError::DATATYPE_ERROR,
+                            "Failed ot creat sync node.",
+                            syncer::BOOKMARKS);
+    error_handler->OnSingleDataTypeUnrecoverableError(error);
     return syncer::kInvalidId;
   }
 
@@ -321,8 +331,11 @@ int64 BookmarkChangeProcessor::UpdateSyncNode(
   // Lookup the sync node that's associated with |node|.
   syncer::WriteNode sync_node(trans);
   if (!associator->InitSyncNodeFromChromeId(node->id(), &sync_node)) {
-    error_handler->OnSingleDatatypeUnrecoverableError(
-        FROM_HERE, "Could not load bookmark node on update.");
+    syncer::SyncError error(FROM_HERE,
+                            syncer::SyncError::DATATYPE_ERROR,
+                            "Failed to init sync node from chrome node",
+                            syncer::BOOKMARKS);
+    error_handler->OnSingleDataTypeUnrecoverableError(error);
     return syncer::kInvalidId;
   }
   UpdateSyncNodeProperties(node, model, &sync_node);
@@ -356,15 +369,21 @@ void BookmarkChangeProcessor::BookmarkNodeMoved(BookmarkModel* model,
     // Lookup the sync node that's associated with |child|.
     syncer::WriteNode sync_node(&trans);
     if (!model_associator_->InitSyncNodeFromChromeId(child->id(), &sync_node)) {
-      error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                          std::string());
+      syncer::SyncError error(FROM_HERE,
+                              syncer::SyncError::DATATYPE_ERROR,
+                              "Failed to init sync node from chrome node",
+                              syncer::BOOKMARKS);
+      error_handler()->OnSingleDataTypeUnrecoverableError(error);
       return;
     }
 
     if (!PlaceSyncNode(MOVE, new_parent, new_index, &trans, &sync_node,
                        model_associator_)) {
-      error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                          std::string());
+      syncer::SyncError error(FROM_HERE,
+                              syncer::SyncError::DATATYPE_ERROR,
+                              "Failed to place sync node",
+                              syncer::BOOKMARKS);
+      error_handler()->OnSingleDataTypeUnrecoverableError(error);
       return;
     }
   }
@@ -396,8 +415,11 @@ void BookmarkChangeProcessor::BookmarkNodeChildrenReordered(
       syncer::WriteNode sync_child(&trans);
       if (!model_associator_->InitSyncNodeFromChromeId(child->id(),
                                                        &sync_child)) {
-        error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                            std::string());
+        syncer::SyncError error(FROM_HERE,
+                                syncer::SyncError::DATATYPE_ERROR,
+                                "Failed to init sync node from chrome node",
+                                syncer::BOOKMARKS);
+        error_handler()->OnSingleDataTypeUnrecoverableError(error);
         return;
       }
       DCHECK_EQ(sync_child.GetParentId(),
@@ -405,8 +427,11 @@ void BookmarkChangeProcessor::BookmarkNodeChildrenReordered(
 
       if (!PlaceSyncNode(MOVE, node, i, &trans, &sync_child,
                          model_associator_)) {
-        error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-                                                            std::string());
+        syncer::SyncError error(FROM_HERE,
+                                syncer::SyncError::DATATYPE_ERROR,
+                                "Failed to place sync node",
+                                syncer::BOOKMARKS);
+        error_handler()->OnSingleDataTypeUnrecoverableError(error);
         return;
       }
     }
@@ -528,8 +553,11 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(
                                          model->other_node()->child_count(),
                                          base::string16());
         if (!foster_parent) {
-          error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-              "Failed to create foster parent.");
+          syncer::SyncError error(FROM_HERE,
+                                  syncer::SyncError::DATATYPE_ERROR,
+                                  "Failed to create foster parent",
+                                  syncer::BOOKMARKS);
+          error_handler()->OnSingleDataTypeUnrecoverableError(error);
           return;
         }
       }
@@ -586,8 +614,11 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(
 
     syncer::ReadNode src(trans);
     if (src.InitByIdLookup(it->id) != syncer::BaseNode::INIT_OK) {
-      error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
-          "ApplyModelChanges was passed a bad ID");
+      syncer::SyncError error(FROM_HERE,
+                              syncer::SyncError::DATATYPE_ERROR,
+                              "Failed to load sync node",
+                              syncer::BOOKMARKS);
+      error_handler()->OnSingleDataTypeUnrecoverableError(error);
       return;
     }