Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/browser/sync/glue/bookmark_model_associator.cc

Issue 436733002: [Sync] Use OnSingleDataTypeUnrecoverableError for all errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bookmark_model_associator.cc
diff --git a/chrome/browser/sync/glue/bookmark_model_associator.cc b/chrome/browser/sync/glue/bookmark_model_associator.cc
index 4ea6b9cbffb27d1e1ec0a2234a6afb995e44d0a0..c77bf967c75f2f7b100be31979c5c55ab51a5059 100644
--- a/chrome/browser/sync/glue/bookmark_model_associator.cc
+++ b/chrome/browser/sync/glue/bookmark_model_associator.cc
@@ -730,9 +730,12 @@ void BookmarkModelAssociator::PersistAssociations() {
int64 sync_id = *iter;
syncer::WriteNode sync_node(&trans);
if (sync_node.InitByIdLookup(sync_id) != syncer::BaseNode::INIT_OK) {
- unrecoverable_error_handler_->OnSingleDatatypeUnrecoverableError(
+ syncer::SyncError error(
FROM_HERE,
- "Could not lookup bookmark node for ID persistence.");
+ syncer::SyncError::DATATYPE_ERROR,
+ "Could not lookup bookmark node for ID persistence.",
+ syncer::BOOKMARKS);
+ unrecoverable_error_handler_->OnSingleDataTypeUnrecoverableError(error);
return;
}
const BookmarkNode* node = GetChromeNodeFromSyncId(sync_id);

Powered by Google App Engine
This is Rietveld 408576698