Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/core/rendering/RenderLayerFilterInfo.cpp

Issue 436693002: Get rid of RenderLayer tracking in RenderSVGResourceContainer. Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove RenderLayer::filterNeedsPaintInvalidation() (now unused). Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 // Reference is external; wait for notifyFinished(). 127 // Reference is external; wait for notifyFinished().
128 cachedSVGDocument->addClient(this); 128 cachedSVGDocument->addClient(this);
129 m_externalSVGReferences.append(cachedSVGDocument); 129 m_externalSVGReferences.append(cachedSVGDocument);
130 } else { 130 } else {
131 // Reference is internal; add layer as a client so we can trigger 131 // Reference is internal; add layer as a client so we can trigger
132 // filter repaint on SVG attribute change. 132 // filter repaint on SVG attribute change.
133 Element* filter = m_layer->renderer()->node()->document().getElement ById(referenceFilterOperation->fragment()); 133 Element* filter = m_layer->renderer()->node()->document().getElement ById(referenceFilterOperation->fragment());
134 if (!isSVGFilterElement(filter)) 134 if (!isSVGFilterElement(filter))
135 continue; 135 continue;
136 if (filter->renderer()) 136 if (filter->renderer())
137 toRenderSVGResourceContainer(filter->renderer())->addClientRende rLayer(m_layer); 137 toRenderSVGResourceContainer(filter->renderer())->addClient(m_la yer->renderer());
138 else 138 else
139 toSVGFilterElement(filter)->addClient(m_layer->renderer()->node( )); 139 toSVGFilterElement(filter)->addClient(m_layer->renderer()->node( ));
140 m_internalSVGReferences.append(filter); 140 m_internalSVGReferences.append(filter);
141 } 141 }
142 } 142 }
143 } 143 }
144 144
145 void RenderLayerFilterInfo::removeReferenceFilterClients() 145 void RenderLayerFilterInfo::removeReferenceFilterClients()
146 { 146 {
147 for (size_t i = 0; i < m_externalSVGReferences.size(); ++i) 147 for (size_t i = 0; i < m_externalSVGReferences.size(); ++i)
148 m_externalSVGReferences.at(i)->removeClient(this); 148 m_externalSVGReferences.at(i)->removeClient(this);
149 m_externalSVGReferences.clear(); 149 m_externalSVGReferences.clear();
150 for (size_t i = 0; i < m_internalSVGReferences.size(); ++i) { 150 for (size_t i = 0; i < m_internalSVGReferences.size(); ++i) {
151 Element* filter = m_internalSVGReferences.at(i).get(); 151 Element* filter = m_internalSVGReferences.at(i).get();
152 if (filter->renderer()) 152 if (filter->renderer())
153 toRenderSVGResourceContainer(filter->renderer())->removeClientRender Layer(m_layer); 153 toRenderSVGResourceContainer(filter->renderer())->removeClient(m_lay er->renderer());
154 else 154 else
155 toSVGFilterElement(filter)->removeClient(m_layer->renderer()->node() ); 155 toSVGFilterElement(filter)->removeClient(m_layer->renderer()->node() );
156 } 156 }
157 m_internalSVGReferences.clear(); 157 m_internalSVGReferences.clear();
158 } 158 }
159 159
160 } // namespace blink 160 } // namespace blink
161 161
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/svg/RenderSVGResourceContainer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698