Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: media/cast/test/utility/standalone_cast_environment.h

Issue 436673004: Fix flaky cast_unittests where threads were being joined incorrectly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/test/utility/standalone_cast_environment.h
diff --git a/media/cast/test/utility/standalone_cast_environment.h b/media/cast/test/utility/standalone_cast_environment.h
index 262f7d6e577d2e5150cb4483c5a6df8e5e2c8c56..91240e1ce55bef79e1b432bccbc47c5ed0fc81ef 100644
--- a/media/cast/test/utility/standalone_cast_environment.h
+++ b/media/cast/test/utility/standalone_cast_environment.h
@@ -14,6 +14,10 @@ namespace cast {
// A complete CastEnvironment where all task runners are spurned from
// internally-owned threads. Uses base::DefaultTickClock as a clock.
+//
+// A user of StandaloneCastEnvironment *must* call Shutdown() on the same thread
+// that constructed the instance before the ref-count reaches zero.
+// http://crbug.com/396480
class StandaloneCastEnvironment : public CastEnvironment,
public base::ThreadChecker {
public:
« no previous file with comments | « media/cast/receiver/video_decoder_unittest.cc ('k') | media/cast/test/utility/standalone_cast_environment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698