Source/core/testing/Internals.cpp - Issue 436673003: Fix crash in blink::Internals::numberOfScrollableAreas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.cpp

Issue 436673003: Fix crash in blink::Internals::numberOfScrollableAreas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scrolling/scrollable-area-internals-crash.html ('K') | « LayoutTests/fast/scrolling/scrollable-area-internals-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/testing/Internals.cpp

diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp

index 13f0a035c1e34c8b93ffef5c0e14801c57a8daf3..21d32f36bf34461d1c15ea105a2b4333d198fe04 100644

--- a/Source/core/testing/Internals.cpp

+++ b/Source/core/testing/Internals.cpp

@@ -1617,6 +1617,9 @@ bool Internals::hasGrammarMarker(Document* document, int from, int length, Excep

unsigned Internals::numberOfScrollableAreas(Document* document, ExceptionState&)

{

+ if (!document || !document->frame())

+ return 0;

unsigned count = 0;

LocalFrame* frame = document->frame();

if (frame->view()->scrollableAreas())