Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
436673003:
Fix crash in blink::Internals::numberOfScrollableAreas (Closed)
DescriptionFix crash in blink::Internals::numberOfScrollableAreas
The frame can be gone since there could have been a navigation that
removes it, as the testcase demonstrates. So like other methods
in Internals test for it first.
BUG=381066
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179367
Patch Set 1 #
Total comments: 1
Patch Set 2 : Remove test #Messages
Total messages: 18 (0 generated)
Fix crash in WebCore::Internals::numberOfScrollableAreas The frame can be gone since there could have been a navigation that removes it, as the testcase demonstrates. So like other methods in Internals test for it first.
PTAL. If this is not your expertise feel free to add another reviewer :)
CL description: > Fix crash in WebCore::Internals::numberOfScrollableAreas WebCore:: -> blink::
https://codereview.chromium.org/436673003/diff/1/LayoutTests/fast/scrolling/s... File LayoutTests/fast/scrolling/scrollable-area-internals-crash.html (right): https://codereview.chromium.org/436673003/diff/1/LayoutTests/fast/scrolling/s... LayoutTests/fast/scrolling/scrollable-area-internals-crash.html:1: <body onload="runTest();"> Please remove this file. We don't need a test for testing code.
On 2014/08/01 00:22:38, tkent wrote: > https://codereview.chromium.org/436673003/diff/1/LayoutTests/fast/scrolling/s... > File LayoutTests/fast/scrolling/scrollable-area-internals-crash.html (right): > > https://codereview.chromium.org/436673003/diff/1/LayoutTests/fast/scrolling/s... > LayoutTests/fast/scrolling/scrollable-area-internals-crash.html:1: <body > onload="runTest();"> > Please remove this file. > We don't need a test for testing code. Fixed! Also did s/WebKit/blink in the summary.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/436673003/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19995)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20004)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/436673003/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20010)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20022)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/436673003/20001
Message was sent while issue was closed.
Change committed as 179367 |
