runtime/vm/intermediate_language_ia32.cc - Issue 436643002: Faster IC stubs by specializing them for Binary Smi operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 436643002: Faster IC stubs by specializing them for Binary Smi operations (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 39456)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -5198,7 +5198,7 @@

void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

Label* deopt = compiler->AddDeoptStub(

deopt_id(), ICData::kDeoptPolymorphicInstanceCallTestFail);

- if (ic_data().NumberOfChecks() == 0) {

+ if (ic_data().NumberOfUsedChecks() == 0) {

Florian Schneider 2014/09/18 12:32:29 Why is this only changed on ia32? This also seems

srdjan 2014/09/25 17:40:25 This was fixed in a follow up CL

__ jmp(deopt);

return;

}

« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »