Source/core/xml/XPathNodeSet.cpp - Issue 436603003: Make Element::attributes() less error-prone and simplify call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathNodeSet.cpp

Issue 436603003: Make Element::attributes() less error-prone and simplify call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/XPathNodeSet.cpp

diff --git a/Source/core/xml/XPathNodeSet.cpp b/Source/core/xml/XPathNodeSet.cpp

index 9a5aa0ec966a49d6d90975e301875dc99e64e049..33b619180fb10ab9e869343e7a539ece706e4b25 100644

--- a/Source/core/xml/XPathNodeSet.cpp

+++ b/Source/core/xml/XPathNodeSet.cpp

@@ -234,9 +234,6 @@ void NodeSet::traversalSort() const

continue;

Element* element = toElement(n);

- if (!element->hasAttributes())

- continue;

AttributeCollection attributes = element->attributes();

AttributeCollection::const_iterator end = attributes.end();

for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it) {

« no previous file with comments | « Source/core/xml/XPathFunctions.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »