Source/core/html/HTMLEmbedElement.cpp - Issue 436603003: Make Element::attributes() less error-prone and simplify call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 436603003: Make Element::attributes() less error-prone and simplify call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLEmbedElement.cpp

diff --git a/Source/core/html/HTMLEmbedElement.cpp b/Source/core/html/HTMLEmbedElement.cpp

index bb55120fc640e9a7ba6207787d21a88fb013d82e..66735b5fe1fd97e502f593c9c417fefc729ad00c 100644

--- a/Source/core/html/HTMLEmbedElement.cpp

+++ b/Source/core/html/HTMLEmbedElement.cpp

@@ -113,9 +113,6 @@ void HTMLEmbedElement::parseAttribute(const QualifiedName& name, const AtomicStr

void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<String>& paramValues)

{

- if (!hasAttributes())

- return;

AttributeCollection attributes = this->attributes();

AttributeCollection::const_iterator end = attributes.end();

for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it) {

« no previous file with comments | « Source/core/editing/markup.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »