Make Element::attributes() less error-prone and simplify call sites

Source/core/editing/MarkupAccumulator.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 367 matching lines @@
     result.append(target);
     result.append(' ');
     result.append(data);
     result.appendLiteral("?>");
 }
 
 void MarkupAccumulator::appendElement(StringBuilder& result, Element& element, Namespaces* namespaces)
 {
     appendOpenTag(result, element, namespaces);
 
-    if (element.hasAttributes()) {
-        AttributeCollection attributes = element.attributes();
-        AttributeCollection::const_iterator end = attributes.end();
-        for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it)
-            appendAttribute(result, element, *it, namespaces);
-    }
+    AttributeCollection attributes = element.attributes();
+    AttributeCollection::const_iterator end = attributes.end();
+    for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it)
+        appendAttribute(result, element, *it, namespaces);
 
     // Give an opportunity to subclasses to add their own attributes.
     appendCustomAttributes(result, element, namespaces);
 
     appendCloseTag(result, element);
 }
 
 static String nodeNamePreservingCase(const Element& element)
 {
     return element.tagQName().toString();
@@ skipping 157 matching lines @@
 }
 
 bool MarkupAccumulator::serializeAsHTMLDocument(const Node& node) const
 {
     if (m_serializationType == ForcedXML)
         return false;
     return node.document().isHTMLDocument();
 }
 
 }