Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 436603002: Enable Screen Orientation integration tests for Chrome OS and Android. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@reduce_flakiness
Project:
chromium
Visibility:
Public.

Description

Enable Screen Orientation integration tests for Chrome OS and Android. MacOS is still broken. Chrome OS got fixed by the previous fix. Android was broken by a not required NOTREACHED(). BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287318

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : +android -macos #

Patch Set 4 : wait for first paint #

Patch Set 5 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 1 2 3 4 3 chunks +15 lines, -5 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/test_navigation_observer.h View 1 2 3 4 chunks +15 lines, -0 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 1 2 3 4 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-07-31 16:03:43 UTC) #1
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-07-31 16:04:21 UTC) #2
jam
lgtm
6 years, 4 months ago (2014-07-31 22:06:35 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-01 10:13:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/436603002/40001
6 years, 4 months ago (2014-08-01 10:14:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-01 11:02:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 11:29:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/562)
6 years, 4 months ago (2014-08-01 11:29:55 UTC) #8
mlamouri (slow - plz ping)
jam@, I had to do a change in TestNavigationObserver. Could you have a look?
6 years, 4 months ago (2014-08-01 16:12:47 UTC) #9
mlamouri (slow - plz ping)
On 2014/08/01 16:12:47, Mounir Lamouri wrote: > jam@, I had to do a change in ...
6 years, 4 months ago (2014-08-04 09:32:58 UTC) #10
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-04 09:33:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/436603002/80001
6 years, 4 months ago (2014-08-04 09:33:25 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 11:20:53 UTC) #13
Message was sent while issue was closed. 
Change committed as 287318

Powered by Google App Engine
This is Rietveld 408576698