Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/ui/autofill/country_combobox_model.cc

Issue 436563005: Turn Autofill country text input into a Spinner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs found bugs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/android/autofill/country_adapter_android.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/country_combobox_model.cc
diff --git a/chrome/browser/ui/autofill/country_combobox_model.cc b/chrome/browser/ui/autofill/country_combobox_model.cc
index fda64cb4407d06e7e507e3f2c62be4a13dfa2154..5cff94340daf927a3e801f8a5183731a133ba9c0 100644
--- a/chrome/browser/ui/autofill/country_combobox_model.cc
+++ b/chrome/browser/ui/autofill/country_combobox_model.cc
@@ -39,8 +39,11 @@ void CountryComboboxModel::SetCountries(
const std::string& app_locale = g_browser_process->GetApplicationLocale();
if (filter.is_null() || filter.Run(default_country_code)) {
countries_.push_back(new AutofillCountry(default_country_code, app_locale));
- // The separator item.
+#if !defined(OS_ANDROID)
+ // The separator item. On Android, there are separators after all items, so
+ // this is unnecessary.
countries_.push_back(NULL);
+#endif
}
// The sorted list of countries.
« no previous file with comments | « chrome/browser/ui/android/autofill/country_adapter_android.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698