Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 436563005: Turn Autofill country text input into a Spinner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs found bugs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 847fd02aafdd6223bed6193d90c9e0dab5efaa9a..f6f729d21be6b60d0f1e53f355161c21f7123465 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -43,30 +43,20 @@ ScopedJavaLocalRef<jobject> CreateJavaProfileFromNative(
ConvertUTF16ToJavaString(env, profile.GetRawInfo(NAME_FULL)).obj(),
ConvertUTF16ToJavaString(env, profile.GetRawInfo(COMPANY_NAME)).obj(),
ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_STREET_ADDRESS)).obj(),
- ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_STATE)).obj(),
- ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_CITY)).obj(),
- ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_DEPENDENT_LOCALITY)).obj(),
- ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_ZIP)).obj(),
- ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(ADDRESS_HOME_SORTING_CODE)).obj(),
+ env, profile.GetRawInfo(ADDRESS_HOME_STREET_ADDRESS)).obj(),
+ ConvertUTF16ToJavaString(env, profile.GetRawInfo(ADDRESS_HOME_STATE))
+ .obj(),
+ ConvertUTF16ToJavaString(env, profile.GetRawInfo(ADDRESS_HOME_CITY))
+ .obj(),
ConvertUTF16ToJavaString(
- env,
- profile.GetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
- g_browser_process->GetApplicationLocale())).obj(),
+ env, profile.GetRawInfo(ADDRESS_HOME_DEPENDENT_LOCALITY)).obj(),
+ ConvertUTF16ToJavaString(env, profile.GetRawInfo(ADDRESS_HOME_ZIP)).obj(),
ConvertUTF16ToJavaString(
- env,
- profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER)).obj(),
+ env, profile.GetRawInfo(ADDRESS_HOME_SORTING_CODE)).obj(),
+ ConvertUTF16ToJavaString(env, profile.GetRawInfo(ADDRESS_HOME_COUNTRY))
+ .obj(),
+ ConvertUTF16ToJavaString(env, profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER))
+ .obj(),
ConvertUTF16ToJavaString(env, profile.GetRawInfo(EMAIL_ADDRESS)).obj(),
ConvertUTF8ToJavaString(env, profile.language_code()).obj());
}
@@ -118,11 +108,10 @@ void PopulateNativeProfileFromJava(
ConvertJavaStringToUTF16(
Java_AutofillProfile_getSortingCode(env, jprofile)),
g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_COUNTRY),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getCountry(env, jprofile)),
- g_browser_process->GetApplicationLocale());
+ profile->SetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getCountryCode(env, jprofile)),
+ g_browser_process->GetApplicationLocale());
profile->SetInfo(
AutofillType(PHONE_HOME_WHOLE_NUMBER),
ConvertJavaStringToUTF16(
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/ui/android/autofill/country_adapter_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698