Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4110)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

Issue 436563005: Turn Autofill country text input into a Spinner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs found bugs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
index 141b50a1cd5af01db7cce1dcc75d0c1ddeac7da0..bb685e5f979ece1af0b8fdc75c04878d7733d678 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
@@ -47,7 +47,7 @@ public class PersonalDataManager {
private String mDependentLocality;
private String mPostalCode;
private String mSortingCode;
- private String mCountry;
+ private String mCountryCode;
private String mPhoneNumber;
private String mEmailAddress;
private String mLabel;
@@ -70,7 +70,7 @@ public class PersonalDataManager {
String region,
String locality, String dependentLocality,
String postalCode, String sortingCode,
- String country, String phoneNumber, String emailAddress, String languageCode) {
+ String countryCode, String phoneNumber, String emailAddress, String languageCode) {
mGUID = guid;
mOrigin = origin;
mFullName = fullName;
@@ -81,7 +81,7 @@ public class PersonalDataManager {
mDependentLocality = dependentLocality;
mPostalCode = postalCode;
mSortingCode = sortingCode;
- mCountry = country;
+ mCountryCode = countryCode;
mPhoneNumber = phoneNumber;
mEmailAddress = emailAddress;
mLanguageCode = languageCode;
@@ -142,12 +142,8 @@ public class PersonalDataManager {
}
@CalledByNative("AutofillProfile")
- public String getCountry() {
- return mCountry;
- }
-
public String getCountryCode() {
- return nativeToCountryCode(mCountry);
+ return mCountryCode;
}
@CalledByNative("AutofillProfile")
@@ -209,8 +205,8 @@ public class PersonalDataManager {
mSortingCode = sortingCode;
}
- public void setCountry(String country) {
- mCountry = country;
+ public void setCountryCode(String countryCode) {
+ mCountryCode = countryCode;
}
public void setPhoneNumber(String phoneNumber) {

Powered by Google App Engine
This is Rietveld 408576698