Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: chrome/browser/ui/autofill/country_combobox_model.cc

Issue 436563005: Turn Autofill country text input into a Spinner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/country_combobox_model.cc
diff --git a/chrome/browser/ui/autofill/country_combobox_model.cc b/chrome/browser/ui/autofill/country_combobox_model.cc
index fda64cb4407d06e7e507e3f2c62be4a13dfa2154..97e882b88786dc8fe80c8c717522508c970bc8f1 100644
--- a/chrome/browser/ui/autofill/country_combobox_model.cc
+++ b/chrome/browser/ui/autofill/country_combobox_model.cc
@@ -39,8 +39,10 @@ void CountryComboboxModel::SetCountries(
const std::string& app_locale = g_browser_process->GetApplicationLocale();
if (filter.is_null() || filter.Run(default_country_code)) {
countries_.push_back(new AutofillCountry(default_country_code, app_locale));
+#if !defined(OS_ANDROID)
aurimas (slooooooooow) 2014/08/01 15:18:21 We don't cant separators in Android UI?
Evan Stade 2014/08/01 18:59:23 there are already separators between every item in
aurimas (slooooooooow) 2014/08/04 15:37:03 Can you add a comment explaining that?
Evan Stade 2014/08/04 20:36:04 Done.
// The separator item.
countries_.push_back(NULL);
+#endif
}
// The sorted list of countries.

Powered by Google App Engine
This is Rietveld 408576698