Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: src/runtime.cc

Issue 436523002: Make GCMole happy about Runtime_ForInFoo methods. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 2a0234bd7c05511c11c1e8272a4f8643b9bec489..cb2e8df05d7eea384c6160b52602f2906426383a 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -15143,8 +15143,8 @@ RUNTIME_FUNCTION_RETURN_PAIR(Runtime_ForInInit) {
// This simulates CONVERT_ARG_HANDLE_CHECKED for calls returning pairs.
// Not worth creating a macro atm as this function should be removed.
if (!args[0]->IsJSReceiver() || !args[1]->IsObject()) {
- return MakePair(isolate->ThrowIllegalOperation(),
- isolate->heap()->undefined_value());
+ Object* error = isolate->ThrowIllegalOperation();
+ return MakePair(error, isolate->heap()->undefined_value());
}
Handle<JSReceiver> object = args.at<JSReceiver>(0);
Handle<Object> cache_type = args.at<Object>(1);
@@ -15197,8 +15197,8 @@ RUNTIME_FUNCTION_RETURN_PAIR(Runtime_ForInNext) {
// Not worth creating a macro atm as this function should be removed.
if (!args[0]->IsJSReceiver() || !args[1]->IsFixedArray() ||
!args[2]->IsObject() || !args[3]->IsSmi()) {
- return MakePair(isolate->ThrowIllegalOperation(),
- isolate->heap()->undefined_value());
+ Object* error = isolate->ThrowIllegalOperation();
+ return MakePair(error, isolate->heap()->undefined_value());
}
Handle<JSReceiver> object = args.at<JSReceiver>(0);
Handle<FixedArray> array = args.at<FixedArray>(1);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698